mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 60162: Fixed bug in GroupTest.ConnectTimer, GroupTest.TimerCleanup.
Date Thu, 22 Jun 2017 08:53:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60162/#review178644
-----------------------------------------------------------



Patch looks great!

Reviews applied: [60161, 60162]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On June 16, 2017, 8:26 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60162/
> -----------------------------------------------------------
> 
> (Updated June 16, 2017, 8:26 p.m.)
> 
> 
> Review request for mesos and Andrei Budnik.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These tests looked for dispatches to `GroupProces::expired` as a way to
> determine when the current Zk session has expired. However, the previous
> implementation of the connect timer (`GroupProcess::timedout`) invoked
> `GroupProcess::expired` directly, which meant that an `EXPECT_DISPATCH`
> on the `expired` method should not fire.
> 
> However, a separate bug in `EXPECT_DISPATCH` (MESOS-5886) meant that the
> test expectations were actually being satisfied by a dispatch to
> `GroupProcess::timedout`, which meant the tests happened to work (!).
> 
> Fix this by changing `GroupProcess::timedout` to dispatch to `expired`
> rather than invoking it directly.
> 
> 
> Diffs
> -----
> 
>   src/zookeeper/group.cpp 20f1928e05123d362147ce4ab0d6a752d95e466d 
> 
> 
> Diff: https://reviews.apache.org/r/60162/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Validated that if the fix for MESOS-5886 is applied without this change, `GroupTest.ConnectTimer`
fails. With this change, the test passes (both with and without the fix for MESOS-5886 applied).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message