-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60162/#review178641
-----------------------------------------------------------
Ship it!
Ship It!
- Andrei Budnik
On June 16, 2017, 6:26 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60162/
> -----------------------------------------------------------
>
> (Updated June 16, 2017, 6:26 p.m.)
>
>
> Review request for mesos and Andrei Budnik.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These tests looked for dispatches to `GroupProces::expired` as a way to
> determine when the current Zk session has expired. However, the previous
> implementation of the connect timer (`GroupProcess::timedout`) invoked
> `GroupProcess::expired` directly, which meant that an `EXPECT_DISPATCH`
> on the `expired` method should not fire.
>
> However, a separate bug in `EXPECT_DISPATCH` (MESOS-5886) meant that the
> test expectations were actually being satisfied by a dispatch to
> `GroupProcess::timedout`, which meant the tests happened to work (!).
>
> Fix this by changing `GroupProcess::timedout` to dispatch to `expired`
> rather than invoking it directly.
>
>
> Diffs
> -----
>
> src/zookeeper/group.cpp 20f1928e05123d362147ce4ab0d6a752d95e466d
>
>
> Diff: https://reviews.apache.org/r/60162/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> Validated that if the fix for MESOS-5886 is applied without this change, `GroupTest.ConnectTimer`
fails. With this change, the test passes (both with and without the fix for MESOS-5886 applied).
>
>
> Thanks,
>
> Neil Conway
>
>
|