mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 60353: Allowed dashes in Python modules.
Date Thu, 22 Jun 2017 00:57:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60353/
-----------------------------------------------------------

Review request for mesos, Armand Grillet and Benjamin Bannier.


Bugs: MESOS-6390
    https://issues.apache.org/jira/browse/MESOS-6390


Repository: mesos


Description
-------

None of our support scripts are intended to be used as modules, so
the usage of dashes in the filenames are acceptable.  PyLint however
considers dashes in module names (same as the filename) to be an error.

This commit also adds the `support` directory to the list of linted
sources.


Diffs
-----

  src/cli_new/pylint.config 63fbb94fbf47cccd1053b4c1eafac18b88dbc818 
  support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec 


Diff: https://reviews.apache.org/r/60353/diff/1/


Testing
-------

This shouldn't be commited yet as a few support scripts don't pass the linter yet.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message