mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 60331: Windows: Disable code using `os::shell()`.
Date Wed, 21 Jun 2017 23:52:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60331/
-----------------------------------------------------------

(Updated June 21, 2017, 11:52 p.m.)


Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu, Li Li,
and Michael Park.


Changes
-------

Update after rebase so Review Bot can apply review.


Bugs: MESOS-6817, MESOS-7371 and MESOS-7407
    https://issues.apache.org/jira/browse/MESOS-6817
    https://issues.apache.org/jira/browse/MESOS-7371
    https://issues.apache.org/jira/browse/MESOS-7407


Repository: mesos


Description
-------

The disabled tests were already disabled, but at runtime instead of
compile time. Deleting `os::shell()` forces us to temporarily disable
the IP discovery command flag until we can move the implementation of
`subprocess()` into stout.


Diffs (updated)
-----

  src/slave/main.cpp 66ae7db4039eedba7ff4eff51495384317c09354 
  src/tests/fetcher_tests.cpp 99149baa1c7abfabf572a0d0f4512a8e84d1e5be 


Diff: https://reviews.apache.org/r/60331/diff/2/

Changes: https://reviews.apache.org/r/60331/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message