-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60229/#review178582
-----------------------------------------------------------
Fix it, then Ship it!
I'll fixup before committing.
support/generate-endpoint-help.py
Lines 49-54 (original), 63-68 (patched)
<https://reviews.apache.org/r/60229/#comment252654>
The leading spaces in multi-line `"""` strings will be kept in the string. For markdown,
this will generate some odd results, as a leading indent is sometimes how you start a code
block.
We should go with:
```
MARKDOWN_HEADER = """---
title: %s
layout: documentation
---
<!--- This is an automatically generated file. DO NOT EDIT! --->
"""
```
```
support/generate-endpoint-help.py
Lines 260-273 (original), 286-299 (patched)
<https://reviews.apache.org/r/60229/#comment252664>
This comment is indented unlike the others :)
- Joseph Wu
On June 20, 2017, 3:14 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60229/
> -----------------------------------------------------------
>
> (Updated June 20, 2017, 3:14 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joseph Wu.
>
>
> Bugs: MESOS-6390
> https://issues.apache.org/jira/browse/MESOS-6390
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will allow us to use PyLint on the
> entire support directory in the future.
>
>
> Diffs
> -----
>
> support/generate-endpoint-help.py 6eb2d41b35c5f064839c29a0ba8326c590a33213
>
>
> Diff: https://reviews.apache.org/r/60229/diff/1/
>
>
> Testing
> -------
>
> Added `support` to `source_dirs` in the PyLinter defined
> in `mesos-style.py`. Linted until only acceptable errors
> where displayed (e.g. due to the name of the file containing
> a dash instead of an underscore).
>
>
> Thanks,
>
> Armand Grillet
>
>
|