mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60228: Linted support/apply-reviews.py.
Date Wed, 21 Jun 2017 22:28:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60228/#review178570
-----------------------------------------------------------


Fix it, then Ship it!





support/apply-reviews.py
Lines 173-176 (original), 208-211 (patched)
<https://reviews.apache.org/r/60228/#comment252633>

    One indent too many here.



support/apply-reviews.py
Line 180 (original), 215 (patched)
<https://reviews.apache.org/r/60228/#comment252634>

    This should have triple double-quotes.


- Joseph Wu


On June 20, 2017, 8:46 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60228/
> -----------------------------------------------------------
> 
> (Updated June 20, 2017, 8:46 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Bugs: MESOS-6390
>     https://issues.apache.org/jira/browse/MESOS-6390
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will allow us to use PyLint on the
> entire support directory in the future.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py 0b1028c66e6b0ba8883d6f4580a95060445df7ac 
> 
> 
> Diff: https://reviews.apache.org/r/60228/diff/2/
> 
> 
> Testing
> -------
> 
> Added `support` to `source_dirs` in the PyLinter defined
> in `mesos-style.py`. Linted until only acceptable errors
> where displayed (e.g. due to the name of the file containing
> a dash instead of an underscore).
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message