mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 60342: Windows: Made version info use Unicode.
Date Wed, 21 Jun 2017 22:17:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60342/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu, Li Li,
and Michael Park.


Bugs: MESOS-6817
    https://issues.apache.org/jira/browse/MESOS-6817


Repository: mesos


Description
-------

The `GetVersionEx` family of functions have been marked deprecated; not
just the non-Unicode version as the previous comment implied. Thus we do
not hide the valid deprecation warning, and should replace the use of
this API.


Diffs
-----

  3rdparty/stout/include/stout/windows/os.hpp f1722d5e18af97d89c6ca7aaf002fd58cb0d21ae 


Diff: https://reviews.apache.org/r/60342/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message