mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 60331: Windows: Disable code using `os::shell()`.
Date Wed, 21 Jun 2017 22:13:04 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 21, 2017, 10:13 p.m.)

Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu, Li Li,
and Michael Park.

Bugs: MESOS-6817, MESOS-7371 and MESOS-7407

Repository: mesos


The disabled tests were already disabled, but at runtime instead of
compile time. Deleting `os::shell()` forces us to temporarily disable
the IP discovery command flag until we can move the implementation of
`subprocess()` into stout.


  src/slave/main.cpp 66ae7db4039eedba7ff4eff51495384317c09354 
  src/tests/fetcher_tests.cpp b4124158a0e92f289f0edc0c8cb9394350e1cbb5 




Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message