mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Review Request 60282: Introduced `upgradeResources` which also validates the resources.
Date Wed, 21 Jun 2017 19:07:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60282/
-----------------------------------------------------------

Review request for mesos and Neil Conway.


Repository: mesos


Description
-------

Validation code for operations, and tasks validated the resources as
the first step, and assumed valid resources from then on. This means
that it started to use functions such as `isDynamicallyReserved`.

However, since `isDynamicallyReserved` requires the resources to be
in the "post-reservation-refinement" format, we must convert the
resources before using those functions. For now, we introduce
a `upgradeResources` abstraction which is called to validate and
convert the resources before invoking operation / task validation.


Diffs
-----

  src/common/resources_utils.hpp 4b033687fa7224ffa36523cb3ca366f4384fd4f8 
  src/common/resources_utils.cpp 751194c5ff5c794c77be3bcf16892af39de6d4d9 


Diff: https://reviews.apache.org/r/60282/diff/1/


Testing
-------


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message