mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60244: Tidied up lambda capture list.
Date Tue, 20 Jun 2017 17:12:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60244/#review178401
-----------------------------------------------------------


Ship it!




Ship It!

- Neil Conway


On June 20, 2017, 2:22 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60244/
> -----------------------------------------------------------
> 
> (Updated June 20, 2017, 2:22 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit removes capture of 'DISK_SIZE' which is neither used in
> the lambda nor captured to extend its lifetime.
> 
> 
> Diffs
> -----
> 
>   src/tests/role_tests.cpp aeef9a7b4062c62efe5036c0c2824c310be00f05 
> 
> 
> Diff: https://reviews.apache.org/r/60244/diff/1/
> 
> 
> Testing
> -------
> 
> make check (clang-5)
> 
> Without this patch this emits a fatal error, with this patch the code compiles successfully.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message