mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 60228: Linted support/apply-reviews.py.
Date Tue, 20 Jun 2017 12:41:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60228/#review178373
-----------------------------------------------------------


Fix it, then Ship it!





support/apply-reviews.py
Line 309 (original), 342 (patched)
<https://reviews.apache.org/r/60228/#comment252302>

    There's no more _the dictionary_, how about e.g.,
    
        """Parses command line options and returns an option dictionary."""



support/apply-reviews.py
Lines 377-378 (original), 400-404 (patched)
<https://reviews.apache.org/r/60228/#comment252303>

    Let's not document our linter here, but instead call out what this function does, e.g.,
    
        """
        This is the main function for the Mesos CLI.
        """


- Benjamin Bannier


On June 20, 2017, 12:13 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60228/
> -----------------------------------------------------------
> 
> (Updated June 20, 2017, 12:13 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Bugs: MESOS-6390
>     https://issues.apache.org/jira/browse/MESOS-6390
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will allow us to use PyLint on the
> entire support directory in the future.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py 0b1028c66e6b0ba8883d6f4580a95060445df7ac 
> 
> 
> Diff: https://reviews.apache.org/r/60228/diff/1/
> 
> 
> Testing
> -------
> 
> Added `support` to `source_dirs` in the PyLinter defined
> in `mesos-style.py`. Linted until only acceptable errors
> where displayed (e.g. due to the name of the file containing
> a dash instead of an underscore).
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message