mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 60236: Linted support/verify-reviews.py.
Date Tue, 20 Jun 2017 11:48:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60236/#review178368
-----------------------------------------------------------


Fix it, then Ship it!





support/verify-reviews.py
Lines 64 (patched)
<https://reviews.apache.org/r/60236/#comment252295>

    `s/Exceptions/Exception/`



support/verify-reviews.py
Lines 218-219 (original)
<https://reviews.apache.org/r/60236/#comment252299>

    Let's keep this variable function-local by picking the right naming scheme, e.g., `rb_date_format`.


- Benjamin Bannier


On June 20, 2017, 12:16 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60236/
> -----------------------------------------------------------
> 
> (Updated June 20, 2017, 12:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Bugs: MESOS-6390
>     https://issues.apache.org/jira/browse/MESOS-6390
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will allow us to use PyLint on the
> entire support directory in the future.
> 
> 
> Diffs
> -----
> 
>   support/verify-reviews.py 391bef5c15a7399f037e54600d1b13c9bd261811 
> 
> 
> Diff: https://reviews.apache.org/r/60236/diff/1/
> 
> 
> Testing
> -------
> 
> Added `support` to `source_dirs` in the PyLinter defined
> in `mesos-style.py`. Linted until only acceptable errors
> where displayed (e.g. due to the name of the file containing
> a dash instead of an underscore).
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message