mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@apache.org>
Subject Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.
Date Tue, 20 Jun 2017 07:44:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58872/
-----------------------------------------------------------

(Updated June 20, 2017, 7:44 a.m.)


Review request for mesos, Benjamin Mahler and Tomasz Janiszewski.


Changes
-------

Rebase.


Bugs: MESOS-4992
    https://issues.apache.org/jira/browse/MESOS-4992


Repository: mesos


Description
-------

Open sandbox link in a new tab would fail since it depends on agents
information loading finish. This patch fixes it by ensuring the agents
information loaded first and then rerouting the sandbox request.


Diffs (updated)
-----

  src/checks/checker_process.hpp 5d0c36dd3e1edf68527fc109d8c0708f09b7e12f 
  src/checks/checker_process.cpp 66f5452bb5f9c7f45819c221be7b098e5999b7a7 
  src/common/resources.cpp ef54678d02c03460dcc01779bf5cd974f486f054 
  src/common/resources_utils.hpp d7d439afdfac92dae51cdd82fc95961f5bfb5c04 
  src/common/resources_utils.cpp 19c89bffcc62224c6a6b195f71caf729b79ed592 
  src/master/validation.cpp bebfe53210b923e94e80f91ced8ea17818bbc807 
  src/v1/resources.cpp c1b6b8a4e5aaa7a45aa59f1808432b831a1c72a6 
  src/webui/master/static/js/controllers.js 1aca25ab6e0856128ebefe5037cbe63430857c99 


Diff: https://reviews.apache.org/r/58872/diff/3/

Changes: https://reviews.apache.org/r/58872/diff/2-3/


Testing
-------


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message