mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 60070: Adjusted the agent to the new resources format [11/N].
Date Tue, 20 Jun 2017 06:58:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60070/#review178348
-----------------------------------------------------------




src/slave/paths.cpp
Lines 478-481 (original), 479-482 (patched)
<https://reviews.apache.org/r/60070/#comment252255>

    Hm.. the `volume.has_role()` check didn't mean that it was necessarily going to be a reserved
resource. Double check whether this is a non-local invariant or not.


- Michael Park


On June 19, 2017, 10:42 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60070/
> -----------------------------------------------------------
> 
> (Updated June 19, 2017, 10:42 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-7666
>     https://issues.apache.org/jira/browse/MESOS-7666
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adjusted the agent to the new resources format [11/N].
> 
> 
> Diffs
> -----
> 
>   src/common/resources_utils.hpp d7d439afdfac92dae51cdd82fc95961f5bfb5c04 
>   src/slave/paths.cpp b2709ad3b111f102ff223182a30c993a0c643230 
>   src/slave/slave.hpp 7ffaed14035a05259ec72c70532ee4f0affa1f5d 
>   src/slave/slave.cpp 91a1bf330c3d5e91ef1b5ed016f9b3d0ad78400f 
>   src/slave/state.hpp a497ce1f58fb8dc7718ee5bb10bc62dd7479efa5 
>   src/slave/state.cpp 18b790d2cc4f537cc9b0c3cca59b9cbaac0eda10 
> 
> 
> Diff: https://reviews.apache.org/r/60070/diff/9/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message