mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 60021: Adjusted (UN)RESERVE operations to handle reservation refinement [8/N].
Date Tue, 20 Jun 2017 05:33:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60021/
-----------------------------------------------------------

(Updated June 19, 2017, 10:33 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7655
    https://issues.apache.org/jira/browse/MESOS-7655


Repository: mesos


Description (updated)
-------

The logic for applying RESERVE operations now needs to ensure that the
pre-reserved resources are being refined. In other words, the RESERVE
operation should be "pushing" a single reservation to the stack. Note
that we only support "pushing" a single reservation at a time.

For UNRESERVE, the operation should "pop" the last reservation off the
stack. We only support "popping" a single reservation at a time.

This patch also replaces all of the uses of `flatten()` to
`toUnreserved()` and also removes `flatten()` entirely. We also replace
the uses of `flatten(role, reservation)` except in tests. We'll remove
this version in later patch.


Diffs (updated)
-----

  include/mesos/resources.hpp be2e377ab9a7332adf373c585e5fafd47ce79f7e 
  include/mesos/v1/resources.hpp fe62166f20088504bdf90a178d3e3b0a94cdc1ac 
  src/cli/execute.cpp 11a2569f788a2ee1ceaf13ab0d40d1d1b275f27a 
  src/common/resources.cpp ef54678d02c03460dcc01779bf5cd974f486f054 
  src/examples/balloon_framework.cpp bfaae3796afb426459ef5cff3a37634a8242032e 
  src/examples/disk_full_framework.cpp a73e6cf285b9a74492d476a624915235e079051f 
  src/examples/long_lived_framework.cpp bbe8606c8d2572bbbbad695e44fa23ce7b6129eb 
  src/examples/test_framework.cpp 05ddc89d953d9b968b78f98fec819aeda7f79e26 
  src/examples/test_http_framework.cpp 471835c349e0da031a540ed48881227a25887ba7 
  src/master/allocator/mesos/hierarchical.cpp 775fe4115d5f55be1e8542fa4f94699396d9e2a1 
  src/master/http.cpp 4f838493104146e1a6b68eb64d8ec122cd54b7f7 
  src/tests/mesos.hpp b93833394f9fe2626f5b8e9d84bb5d336f1eee0b 
  src/tests/reservation_endpoints_tests.cpp ba283ee74fe27998a01c43e1ab6a8ce0089181fa 
  src/tests/resources_tests.cpp a44490a4f4fbd3af3b95c9e9a167a96c6e0f40f9 
  src/v1/resources.cpp c1b6b8a4e5aaa7a45aa59f1808432b831a1c72a6 


Diff: https://reviews.apache.org/r/60021/diff/7/

Changes: https://reviews.apache.org/r/60021/diff/6-7/


Testing
-------


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message