mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Review Request 60218: Added a couple of missing validation logic + minor improvements.
Date Tue, 20 Jun 2017 00:57:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60218/
-----------------------------------------------------------

Review request for mesos and Neil Conway.


Repository: mesos


Description
-------

The `ReservationInfo`s in `Resource.reservations` are required to have
the `type` and `role` fields. This patch adds validation logic to
enforce that. It also makes a few improvements in the error messages
by checking conditions more fine-grained.


Diffs
-----

  src/common/resources.cpp cc305e64cadc9fab913ede987625fc1839646306 
  src/master/validation.cpp 1436002b5e30670166c1564b0e354299cc3a25fd 


Diff: https://reviews.apache.org/r/60218/diff/1/


Testing
-------


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message