mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 60103: Changed variable name _ack to statusUpdateAck.
Date Mon, 19 Jun 2017 22:30:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60103/#review178319
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/slave_recovery_tests.cpp
Line 237 (original), 237 (patched)
<https://reviews.apache.org/r/60103/#comment252203>

    `s/statusUpdateAck/_statusUpdateAcknowledgement/`
    
    Generally for this sitautions ("a future capturing the dispatch of a method") we just
simply copy the name of the method as a the name of the variable.
    
    If you search `Future<Nothing> _statusUpdateAcknowledgement =` in the same file
you can actually see plenty of examples. :)


- Jiang Yan Xu


On June 15, 2017, 12:30 p.m., Megha Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60103/
> -----------------------------------------------------------
> 
> (Updated June 15, 2017, 12:30 p.m.)
> 
> 
> Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6223
>     https://issues.apache.org/jira/browse/MESOS-6223
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed variable name _ack to statusUpdateAck which
> correctly identifies with the purpose of this variable.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c 
> 
> 
> Diff: https://reviews.apache.org/r/60103/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message