mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60210: Disabled emitting unset fields with default values in tests.
Date Mon, 19 Jun 2017 21:20:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60210/#review178304
-----------------------------------------------------------



Can we add a bit more context on the motivation here? i.e., are we always omitting default
values to ensure we roundtrip, or is it just good practice in these situations, etc.?

- Neil Conway


On June 19, 2017, 8:43 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60210/
> -----------------------------------------------------------
> 
> (Updated June 19, 2017, 8:43 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used the new `JSON::protobuf` overload to avoid emitting unset fields.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp 6ca45706f47b7d75db519f98af64e6a52091eb84 
>   src/tests/persistent_volume_endpoints_tests.cpp 0cb969cf06a123504720440f436ecb027d1e138a

>   src/tests/persistent_volume_tests.cpp 787141cdbe0188ba839d3bbd6e5cbb97ff78ce4b 
>   src/tests/reservation_endpoints_tests.cpp ba283ee74fe27998a01c43e1ab6a8ce0089181fa

>   src/tests/resources_tests.cpp a44490a4f4fbd3af3b95c9e9a167a96c6e0f40f9 
>   src/tests/role_tests.cpp 850dfa79646562bd3653a5fd0f079d0226b95970 
> 
> 
> Diff: https://reviews.apache.org/r/60210/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message