-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60209/#review178300
-----------------------------------------------------------
I'm a bit confused on when code should be using `modelProtobufJSON` vs. `JSON::protobuf(...,
false)`. I guess `JSON::protobuf(..., false)` does omits default values in strictly _more_
situations than `modelProtobufJSON` does?
src/common/http.cpp
Line 115 (original), 115 (patched)
<https://reviews.apache.org/r/60209/#comment252192>
Can we add a comment explaining what is going on here?
- Neil Conway
On June 19, 2017, 8:40 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60209/
> -----------------------------------------------------------
>
> (Updated June 19, 2017, 8:40 p.m.)
>
>
> Review request for mesos, Neil Conway and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/http.cpp 98899a789610add924a7d2c0af943230cf914d2d
>
>
> Diff: https://reviews.apache.org/r/60209/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
|