mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60207: Added `emit_default_value` option to `JSON::protobuf`.
Date Mon, 19 Jun 2017 21:08:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60207/#review178294
-----------------------------------------------------------


Fix it, then Ship it!




Needs test coverage.


3rdparty/stout/include/stout/protobuf.hpp
Line 835 (original), 835 (patched)
<https://reviews.apache.org/r/60207/#comment252183>

    Update this comment.


- Neil Conway


On June 19, 2017, 8:40 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60207/
> -----------------------------------------------------------
> 
> (Updated June 19, 2017, 8:40 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/protobuf.hpp 2735354256f35d2792c3690bcc8fc61c3f6d9524

> 
> 
> Diff: https://reviews.apache.org/r/60207/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message