mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 60182: Resources: Adjusted the predicates to the new resource format [2/N].
Date Mon, 19 Jun 2017 13:32:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60182/#review178234
-----------------------------------------------------------




include/mesos/resources.hpp
Lines 266-269 (original), 266-271 (patched)
<https://reviews.apache.org/r/60182/#comment252109>

    This means that frameworks using `Resources` *have* to be updated to support the `RESERVATION_REFINEMENT`
capability, otherwise they won't be able to use a `Resources` instance created from old `Resource`
objects as offered by Mesos.



src/common/resources.cpp
Lines 1036-1037 (patched)
<https://reviews.apache.org/r/60182/#comment252110>

    Why add these checks for every predicate function even those that don't handle reservations?


- Jan Schlicht


On June 19, 2017, 7:23 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60182/
> -----------------------------------------------------------
> 
> (Updated June 19, 2017, 7:23 a.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-7655
>     https://issues.apache.org/jira/browse/MESOS-7655
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp be2e377ab9a7332adf373c585e5fafd47ce79f7e 
>   include/mesos/v1/resources.hpp fe62166f20088504bdf90a178d3e3b0a94cdc1ac 
>   src/common/resources.cpp cc305e64cadc9fab913ede987625fc1839646306 
>   src/v1/resources.cpp 03d6c8098a24a2751617d14f2664de1d88318414 
> 
> 
> Diff: https://reviews.apache.org/r/60182/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message