mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 60181: Resources: Updated the comment to mention the resource format [1/N].
Date Mon, 19 Jun 2017 13:10:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60181/#review178233
-----------------------------------------------------------




include/mesos/resources.hpp
Lines 56-63 (original), 56-63 (patched)
<https://reviews.apache.org/r/60181/#comment252105>

    Not new, but I don't fully understand, who that "caller" is. Is it meant a class user?
Or any entity that calls on any method on the class instance? Does this mean that any entity
that uses an instance of this class must leave it in valid state?


- Alexander Rukletsov


On June 19, 2017, 5:17 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60181/
> -----------------------------------------------------------
> 
> (Updated June 19, 2017, 5:17 a.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-7655
>     https://issues.apache.org/jira/browse/MESOS-7655
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp be2e377ab9a7332adf373c585e5fafd47ce79f7e 
>   include/mesos/v1/resources.hpp fe62166f20088504bdf90a178d3e3b0a94cdc1ac 
> 
> 
> Diff: https://reviews.apache.org/r/60181/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message