mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60189: Prevented allocating non-capable agent resources to capable frameworks.
Date Mon, 19 Jun 2017 06:51:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60189/#review178193
-----------------------------------------------------------


Fix it, then Ship it!





src/master/allocator/mesos/hierarchical.cpp
Line 2112 (original), 2112 (patched)
<https://reviews.apache.org/r/60189/#comment252059>

    Not specific to this RR, but if we're going to check non-framework-filters in `isFiltered`,
various comments should be updated. e.g.,
    
    ```
            // If the framework filters these resources, ignore. The unallocated
            // part of the quota will not be allocated to other roles.
            if (isFiltered(frameworkId, role, slaveId, resources)) {
              continue;
            }
    ```
    
    The new semantics of `isFiltered` covers more than "if the framework filters these resources".
    
    Similar with the comment for `isFiltered` in hierarchical.hpp


- Neil Conway


On June 19, 2017, 6:43 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60189/
> -----------------------------------------------------------
> 
> (Updated June 19, 2017, 6:43 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch prevents allocating resources to frameworks with
> `RESERVATION_REFINEMENT` capability with resources from the agents
> without the `RESERVATION_REFINEMENT` capability.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 775fe4115d5f55be1e8542fa4f94699396d9e2a1

> 
> 
> Diff: https://reviews.apache.org/r/60189/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message