mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60036: Avoided exposing `role` in JSON for resources with refined reservations.
Date Mon, 19 Jun 2017 01:46:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60036/#review178172
-----------------------------------------------------------



Tests, can do later.


src/common/http.hpp
Lines 131 (patched)
<https://reviews.apache.org/r/60036/#comment252037>

    Note that it doesn't roundtrip.



src/common/http.hpp
Lines 135 (patched)
<https://reviews.apache.org/r/60036/#comment252036>

    Indentation is non-idiomatic



src/common/http.cpp
Lines 519 (patched)
<https://reviews.apache.org/r/60036/#comment252038>

    Backticks not double quotes?



src/common/http.cpp
Lines 526 (patched)
<https://reviews.apache.org/r/60036/#comment252039>

    Can we add `is<T>` checks here, for safety's sake?


- Neil Conway


On June 15, 2017, 7:39 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60036/
> -----------------------------------------------------------
> 
> (Updated June 15, 2017, 7:39 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7655
>     https://issues.apache.org/jira/browse/MESOS-7655
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With reservation refinement, we use the `Resource.reservations` field to
> express the reservation state. Due to the fact that `Resource.role` is
> an optional field __and__ has a default value, our generic Protobuf to
> JSON code injects the `role` field with the default value even if it's
> not set. Since this will likely confuse users, here we manually remove
> the `Resource.role` field if the resource has refined reservations.
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
>   src/common/http.cpp 167dce2b9a2d3b68a1df5b4079f701482d34db28 
>   src/master/http.cpp e01c3fcdc0df63934fc82ee4c9bf081f54cf7ea2 
>   src/slave/http.cpp 78b35865e465ff1e8e7e4950fdb60e3a48b916b6 
> 
> 
> Diff: https://reviews.apache.org/r/60036/diff/9/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message