mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 60178: Added test for endpoint resource format.
Date Mon, 19 Jun 2017 01:15:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60178/#review178171
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/master_validation_tests.cpp
Lines 292-293 (patched)
<https://reviews.apache.org/r/60178/#comment252028>

    Can we take this one out? It's invalid not because they're inconsistent but rather because
the `ReservationInfo` doesn't have the required fields set. Seems like we have the inconsistency
tests below anyway.


- Michael Park


On June 18, 2017, 6:12 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60178/
> -----------------------------------------------------------
> 
> (Updated June 18, 2017, 6:12 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for endpoint resource format.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_validation_tests.cpp 83370fa5653fe5da666ec577b05001c4a5499848 
> 
> 
> Diff: https://reviews.apache.org/r/60178/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message