mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 60062: Prevented reserve/create with hierarchical roles on a non-capable agent.
Date Fri, 16 Jun 2017 19:48:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60062/
-----------------------------------------------------------

(Updated June 16, 2017, 12:48 p.m.)


Review request for mesos and Neil Conway.


Changes
-------

Addressed the rest of the comments.


Repository: mesos


Description
-------

This patch makes it such that reserve / create operations involving
resources with a hierarchical role are invalid if they are attempted on
an agent without a HIERARCHICAL_ROLE capability. Such attempts from an
operator endpoint will result in a `BadRequest` response. On the
frameworks side, we've opted to not offer resources from
a non-HIERARCHICAL_ROLE agent to hierarchical roles (ca8d33ab).

If we were to undo ca8d33ab, an attempt from a framework to perform such
an operation would be considered invalid due to this patch and the
operation would be dropped by the master.


Diffs (updated)
-----

  src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
  src/master/master.cpp 47a76ba9f549f2a170b5f424ac351e120ba75fb2 
  src/master/validation.hpp 6b53e34f67f6a8b338b92db6cb7398f1dccce5a9 
  src/master/validation.cpp f45f9e816bdaf6304794604570edbd68d5faf715 
  src/tests/master_validation_tests.cpp 4e7ce74edf0069b9317f869b299694a45e2a62f2 


Diff: https://reviews.apache.org/r/60062/diff/9/

Changes: https://reviews.apache.org/r/60062/diff/8-9/


Testing
-------

Added new tests to `master_validation_tests.cpp` + `make check`


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message