mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 60020: Resources: Added `toUnreserved()` and `(push|pop)Reservation`.
Date Fri, 16 Jun 2017 03:34:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60020/#review178052
-----------------------------------------------------------


Fix it, then Ship it!




Modulo comments, be sure to replicate the changes in v1.


include/mesos/resources.hpp
Lines 428-429 (patched)
<https://reviews.apache.org/r/60020/#comment251845>

    Can you put a newline between the comment paragraphs? Ditto on the other TODOs.



include/mesos/resources.hpp
Lines 444-446 (patched)
<https://reviews.apache.org/r/60020/#comment251883>

    Should we CHECK that all of the last reservations we're popping here are to the same role?
That seems to be the only sane use of this function?



include/mesos/resources.hpp
Lines 448-449 (patched)
<https://reviews.apache.org/r/60020/#comment251884>

    All of the reservations removed?


- Benjamin Mahler


On June 15, 2017, 7:40 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60020/
> -----------------------------------------------------------
> 
> (Updated June 15, 2017, 7:40 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7655
>     https://issues.apache.org/jira/browse/MESOS-7655
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patches introduces utilities `toUnreserved`, `pushReservation` and
> `popReservation`. They are intended to replace the current `flatten`.
> We'll switch over to use them once the 'post-reservation-refinement'
> format is used for `Resources`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 2b55847be79c7930b598ef31c932e8aca0fa73db 
>   include/mesos/v1/resources.hpp 7c6e8569b990ad34fd6c449b31140f844dae222f 
>   src/common/resources.cpp 7b3fae1a34150964ba3831a3aef2f868e338aef8 
>   src/v1/resources.cpp 236fe17730918479a33314e51d14f3cc1679d432 
> 
> 
> Diff: https://reviews.apache.org/r/60020/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message