mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 60064: Updated `isAllocatableTo` to use the `roles::isSubroleOf` utility.
Date Fri, 16 Jun 2017 03:01:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60064/#review178077
-----------------------------------------------------------




src/common/resources.cpp
Line 920 (original), 920 (patched)
<https://reviews.apache.org/r/60064/#comment251882>

    Adjust it as necessary with `isStrictSubroleOf`.
    i.e. Add the same role case.


- Michael Park


On June 15, 2017, 12:38 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60064/
> -----------------------------------------------------------
> 
> (Updated June 15, 2017, 12:38 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7655
>     https://issues.apache.org/jira/browse/MESOS-7655
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch simplifies the `isAllocatableTo` function by leveraging
> the `roles::isSubroleOf` function introduced in
> https://reviews.apache.org/r/60064.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 7b3fae1a34150964ba3831a3aef2f868e338aef8 
>   src/v1/resources.cpp 236fe17730918479a33314e51d14f3cc1679d432 
> 
> 
> Diff: https://reviews.apache.org/r/60064/diff/4/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message