mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60070: Updated the agent to account for the new resources format.
Date Thu, 15 Jun 2017 23:40:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60070/#review178018
-----------------------------------------------------------



It would be great to have a comment somewhere (not sure the best place) that describes our
overall approach to representation/evolving resource formats. For example:

* what do we checkpoint to disk at the agent?
* what do we use in-memory at the agent?
* what do we send back to the master?
* what does the master store in Zk?

(One subtle thing is that regardless of what we send back to the master, the `SlaveInfo` in
Zk won't be updated, at least for the time being...)


src/slave/slave.cpp
Line 5926 (original), 5946 (patched)
<https://reviews.apache.org/r/60070/#comment251769>

    This change seems unnecessary, I think?



src/slave/state.hpp
Lines 45 (patched)
<https://reviews.apache.org/r/60070/#comment251770>

    We usually add a newline here, I think.



src/slave/state.cpp
Lines 45 (patched)
<https://reviews.apache.org/r/60070/#comment251771>

    Newline.



src/slave/state.cpp
Line 223 (original), 227 (patched)
<https://reviews.apache.org/r/60070/#comment251772>

    Are we using `const` here but not elsewhere in the RR for a reason?


- Neil Conway


On June 14, 2017, 9:56 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60070/
> -----------------------------------------------------------
> 
> (Updated June 14, 2017, 9:56 a.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-7666
>     https://issues.apache.org/jira/browse/MESOS-7666
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the agent to account for the new resources format.
> 
> 
> Diffs
> -----
> 
>   src/slave/paths.cpp b2709ad3b111f102ff223182a30c993a0c643230 
>   src/slave/slave.hpp 7ffaed14035a05259ec72c70532ee4f0affa1f5d 
>   src/slave/slave.cpp 7d147ac6609933ac884bfc29032dba572a0952c6 
>   src/slave/state.hpp a497ce1f58fb8dc7718ee5bb10bc62dd7479efa5 
>   src/slave/state.cpp 18b790d2cc4f537cc9b0c3cca59b9cbaac0eda10 
> 
> 
> Diff: https://reviews.apache.org/r/60070/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message