mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 59949: Added `MESOS_CONTAINER_IP` to tasks launched by `DefaultExecutor`.
Date Thu, 15 Jun 2017 23:17:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59949/#review178062
-----------------------------------------------------------


Fix it, then Ship it!




Minor comments. I would fix them while committing!


src/launcher/default_executor.cpp
Lines 379-381 (patched)
<https://reviews.apache.org/r/59949/#comment251850>

    ```cpp
    // TODO(asridharan): This won't work when the framework sets the ...
    ```



src/launcher/default_executor.cpp
Lines 384 (patched)
<https://reviews.apache.org/r/59949/#comment251851>

    s/here//



src/launcher/default_executor.cpp
Lines 385 (patched)
<https://reviews.apache.org/r/59949/#comment251849>

    s/from/from the


- Anand Mazumdar


On June 15, 2017, 12:38 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59949/
> -----------------------------------------------------------
> 
> (Updated June 15, 2017, 12:38 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Jie Yu.
> 
> 
> Bugs: MESOS-7631
>     https://issues.apache.org/jira/browse/MESOS-7631
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `MESOS_CONTAINER_IP` to tasks launched by `DefaultExecutor`.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 91a4e1ebed3ff979bd3c0f7f46559cec24f61c2c 
> 
> 
> Diff: https://reviews.apache.org/r/59949/diff/5/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message