mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60041: Devolved reserved resources for the HTTP endpoints.
Date Thu, 15 Jun 2017 19:01:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60041/#review178024
-----------------------------------------------------------



If we're no longer calling "transform reserved resource to old format", can we update the
commit message to not use the phrase "devolve"?


src/common/http.cpp
Lines 347 (patched)
<https://reviews.apache.org/r/60041/#comment251780>

    I wonder whether the transformation should be in `model` and the jsonify `writer`, rather
than in every (?) call-site of those functions. Seems fragile to remember to have to do this
in a lot of different places.


- Neil Conway


On June 13, 2017, 8:43 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60041/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 8:43 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Devolved reserved resources for the HTTP endpoints.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp 167dce2b9a2d3b68a1df5b4079f701482d34db28 
>   src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
>   src/slave/http.cpp 78b35865e465ff1e8e7e4950fdb60e3a48b916b6 
> 
> 
> Diff: https://reviews.apache.org/r/60041/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message