mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 59861: Added protobuf changes for reservation refinement.
Date Thu, 15 Jun 2017 18:59:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59861/#review178027
-----------------------------------------------------------




include/mesos/mesos.proto
Lines 347 (patched)
<https://reviews.apache.org/r/59861/#comment251793>

    It seems like this capability controls _two_ things:
    
    (1) Whether the framework is offered resources using the new resource format.
    
    (2) Whether the framework is offered resources with refined reservations and is allowed
to refine reservations.
    
    Can we clarify this?



include/mesos/mesos.proto
Lines 833 (patched)
<https://reviews.apache.org/r/59861/#comment251794>

    Similarly to the framework capability, would be good to distinguish between the data format
change from actually taking advantage of refined resources.



include/mesos/mesos.proto
Line 947 (original), 1050 (patched)
<https://reviews.apache.org/r/59861/#comment251795>

    "made" rather than "acquired" (the operator doesn't "acquire" the reservation).



include/mesos/v1/mesos.proto
Line 939 (original), 962 (patched)
<https://reviews.apache.org/r/59861/#comment251797>

    Need to sync with unversioned copy of this file.



src/slave/constants.cpp
Line 40 (original), 40 (patched)
<https://reviews.apache.org/r/59861/#comment251796>

    This should add `RESERVATION_REFINEMENT`.


- Neil Conway


On June 15, 2017, 7:37 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59861/
> -----------------------------------------------------------
> 
> (Updated June 15, 2017, 7:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Neil Conway.
> 
> 
> Bugs: MESOS-7575
>     https://issues.apache.org/jira/browse/MESOS-7575
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With reservation refinement, we now represent the reservation state in
> `Resource.reservations` rather than with `Resource.role` and
> `Resource.reservation`. We also keep track of the type of reservation,
> and the role the reservation is for in the `Resource.ReservationInfo`.
> This patch introduces these changes and explains the different formats
> in detail.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto e9a8b1513150b394f4986a1f34483cfca32b35e3 
>   include/mesos/v1/mesos.proto 5e8c15c07a02999e3376d2104c1c642f00511969 
>   src/common/protobuf_utils.hpp 7b1a1289c16edde44143432b645ecc2222e68576 
>   src/common/protobuf_utils.cpp 46331b379c732edc597b46bb10665c95c9640e96 
>   src/slave/constants.cpp d3668e4dca515f42d88d01b0852a543bfdb360f6 
> 
> 
> Diff: https://reviews.apache.org/r/59861/diff/9/
> 
> 
> Testing
> -------
> 
> Updated tests + `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message