mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60069: Updated the master to account for the new resources format.
Date Thu, 15 Jun 2017 08:32:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60069/#review177913
-----------------------------------------------------------




src/master/master.cpp
Line 3492 (original), 3492 (patched)
<https://reviews.apache.org/r/60069/#comment251617>

    Update this comment? i.e., "all roles included in `reserve.resources`" is no longer a
complete description.



src/master/master.cpp
Line 3905 (original), 3905 (patched)
<https://reviews.apache.org/r/60069/#comment251707>

    Seems like this comment needs updating.



src/master/master.cpp
Line 3907 (original), 3907 (patched)
<https://reviews.apache.org/r/60069/#comment251710>

    Confused why this is in the same loop as `injectAllocationInfo`; updating the comment
would help.



src/master/master.cpp
Lines 3908 (patched)
<https://reviews.apache.org/r/60069/#comment251711>

    Do we want to check that if the framework claims to _not_ be aware of reservation refinement,
it has _not_ used the new protobuf fields?



src/master/master.cpp
Line 9247 (original), 9257 (patched)
<https://reviews.apache.org/r/60069/#comment251618>

    Do we use this syntax elsewhere? Seemed a bit surprising to me.



src/master/quota.cpp
Line 145 (original), 150 (patched)
<https://reviews.apache.org/r/60069/#comment251708>

    Do we want to remove this check? Seems like resources with `reservation` should still
be rejected.


- Neil Conway


On June 14, 2017, 9:56 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60069/
> -----------------------------------------------------------
> 
> (Updated June 14, 2017, 9:56 a.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-7667
>     https://issues.apache.org/jira/browse/MESOS-7667
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the master to account for the new resources format.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
>   src/master/master.hpp e8ddddf273256b14cde1cac390163f948241757f 
>   src/master/master.cpp 3c6925dc6055fb7cec12ec03bc557ad462863c58 
>   src/master/quota.cpp 3e0d280efff69904b74e5d4c71985ab44ffa34a7 
>   src/master/validation.cpp f45f9e816bdaf6304794604570edbd68d5faf715 
> 
> 
> Diff: https://reviews.apache.org/r/60069/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message