mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60062: Prevented reserve/create with hierarchical roles on a non-capable agent.
Date Thu, 15 Jun 2017 08:14:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60062/#review177988
-----------------------------------------------------------




src/master/master.cpp
Line 4199 (original), 4205-4206 (patched)
<https://reviews.apache.org/r/60062/#comment251701>

    `error->message`



src/master/master.cpp
Lines 4326 (patched)
<https://reviews.apache.org/r/60062/#comment251702>

    `error->message`



src/master/validation.cpp
Lines 1853 (patched)
<https://reviews.apache.org/r/60062/#comment251704>

    Would it be clearer to say:
    
    ```
    "Resource '" + ... + "' with reservation for hierarchical role '" + ... + "' cannot be
reserved on an agent without HIERARCHICAL_ROLE capability";
    ```
    
    i.e., (a) mention the role name (b) is it accurate/sufficient to say that "resource with
a hierarchical role"? i.e., the resource is _reserved for_ a hierarchical role, it doesn't
"have" a hierarchical role.



src/master/validation.cpp
Lines 2027 (patched)
<https://reviews.apache.org/r/60062/#comment251705>

    Mention the role name here?



src/tests/master_validation_tests.cpp
Lines 820 (patched)
<https://reviews.apache.org/r/60062/#comment251706>

    Do we need to set `hierarchicalRole` here?


- Neil Conway


On June 15, 2017, 7:37 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60062/
> -----------------------------------------------------------
> 
> (Updated June 15, 2017, 7:37 a.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes it such that reserve / create operations involving
> resources with a hierarchical role are invalid if they are attempted on
> an agent without a HIERARCHICAL_ROLE capability. Such attempts from an
> operator endpoint will result in a `BadRequest` response. On the
> frameworks side, we've opted to not offer resources from
> a non-HIERARCHICAL_ROLE agent to hierarchical roles (ca8d33ab).
> 
> If we were to undo ca8d33ab, an attempt from a framework to perform such
> an operation would be considered invalid due to this patch and the
> operation would be dropped by the master.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
>   src/master/master.cpp 3c6925dc6055fb7cec12ec03bc557ad462863c58 
>   src/master/validation.hpp 6b53e34f67f6a8b338b92db6cb7398f1dccce5a9 
>   src/master/validation.cpp f45f9e816bdaf6304794604570edbd68d5faf715 
>   src/tests/master_validation_tests.cpp 4e7ce74edf0069b9317f869b299694a45e2a62f2 
> 
> 
> Diff: https://reviews.apache.org/r/60062/diff/5/
> 
> 
> Testing
> -------
> 
> Added new tests to `master_validation_tests.cpp` + `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message