mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <>
Subject Re: Review Request 60036: Added a hack to avoid printing out the `Resource.role` field.
Date Thu, 15 Jun 2017 07:39:17 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 15, 2017, 12:39 a.m.)

Review request for mesos and Benjamin Mahler.

Bugs: MESOS-7655

Repository: mesos

Description (updated)

With reservation refinement, we use the `Resource.reservations` field
to express the reservation state. Due to the fact that `Resource.role`
is an optional field with a default value, our generic Protobuf to
JSON converter prints out the `role` field even if it's not set.
In order to mitigate the confusion for the users, we introduce a hack
for now to conditionally remove the `role` field.

Diffs (updated)

  include/mesos/resources.hpp 2b55847be79c7930b598ef31c932e8aca0fa73db 
  src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
  src/slave/http.cpp 78b35865e465ff1e8e7e4950fdb60e3a48b916b6 





Michael Park

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message