mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <>
Subject Re: Review Request 59861: Added protobuf changes for reservation refinement.
Date Thu, 15 Jun 2017 07:37:19 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 15, 2017, 12:37 a.m.)

Review request for mesos, Benjamin Mahler and Neil Conway.

Summary (updated)

Added protobuf changes for reservation refinement.

Bugs: MESOS-7575

Repository: mesos

Description (updated)

With reservation refinement, we now represent the reservation state in
`Resource.reservations` rather than with `Resource.role` and
`Resource.reservation`. We also keep track of the type of reservation,
and the role the reservation is for in the `Resource.ReservationInfo`.
This patch introduces these changes and explains the different formats
in detail.

Diffs (updated)

  include/mesos/mesos.proto e9a8b1513150b394f4986a1f34483cfca32b35e3 
  include/mesos/v1/mesos.proto 5e8c15c07a02999e3376d2104c1c642f00511969 
  src/common/protobuf_utils.hpp 7b1a1289c16edde44143432b645ecc2222e68576 
  src/common/protobuf_utils.cpp 46331b379c732edc597b46bb10665c95c9640e96 
  src/slave/constants.cpp d3668e4dca515f42d88d01b0852a543bfdb360f6 




Updated tests + `make check`


Michael Park

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message