mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 60038: Prevented allocating reservation refinements to non-capable frameworks.
Date Wed, 14 Jun 2017 19:23:07 GMT


> On June 14, 2017, 7:04 p.m., Benjamin Mahler wrote:
> >

Also, could you add a description / commit message here with some of the subtleties from our
discussion? E.g.

```
Prevented allocating reservation refinements to non-capable frameworks.

When reservation refinements are present, old frameworks without the
RESERVATION_REFINEMENT capability won't be able to understand the new
format. While it's possible to translate the refined reservations into
the old format by "hiding" the intermediate reservations in the "stack",
this leads to ambiguity when processing RESERVE and UNRESERVE operations.
This is due to the loss of information when we drop the intermediate
reservations. Therefore, for now we simply filter out resources with
refined reservations if the framework does not have the capability.
```

Should probably document this in the code as well?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60038/#review177942
-----------------------------------------------------------


On June 13, 2017, 8:44 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60038/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 8:44 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prevented allocating reservation refinements to non-capable frameworks.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 3428edfca116ffc625b683b6bead48300c2750c4

> 
> 
> Diff: https://reviews.apache.org/r/60038/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message