mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 60041: Devolved reserved resources for the HTTP endpoints.
Date Wed, 14 Jun 2017 19:16:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60041/#review177943
-----------------------------------------------------------


Fix it, then Ship it!




This warrants a review description / commit message. How about:

```
Updated the v0 HTTP endpoints for reservation refinements.

The introduction of the RESERVATION_REFINEMENT capability changed
the format of `Resource` by making `Resource.role` and
`Resource.reservation` unused in favor of `Resource.reservations`.
To preserve backwards compatibility in the v0 HTTP endpoints that
expose JSON, we must "downgrade" to the old format if reservation
refinements are not being used within a resource.
```


src/common/http.cpp
Lines 344-347 (patched)
<https://reviews.apache.org/r/60041/#comment251660>

    Can you add a comment across all of these touch points? E.g.
    
    ```
    The introduction of the RESERVATION_REFINEMENT capability changed
    the format of `Resource` by making `Resource.role` and
    `Resource.reservation` unused in favor of `Resource.reservations`.
    To preserve backwards compatibility, we must "downgrade" to the
    old format if reservation refinement is not being used.
    
    TODO(mpark): Remove this in 2.x? See MESOS-XXXX.
    ```
    
    Would be great to reference a ticket that is about removing this.



src/slave/http.cpp
Lines 1295-1297 (original), 1298-1301 (patched)
<https://reviews.apache.org/r/60041/#comment251661>

    Seems odd to introduce the formatting change here, can you just commit that separately
to keep the diff minimal?


- Benjamin Mahler


On June 13, 2017, 8:43 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60041/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 8:43 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Devolved reserved resources for the HTTP endpoints.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp 167dce2b9a2d3b68a1df5b4079f701482d34db28 
>   src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
>   src/slave/http.cpp 78b35865e465ff1e8e7e4950fdb60e3a48b916b6 
> 
> 
> Diff: https://reviews.apache.org/r/60041/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message