mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 60038: Prevented allocating reservation refinements to non-capable frameworks.
Date Wed, 14 Jun 2017 19:03:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60038/#review177940
-----------------------------------------------------------


Ship it!




Looks good. As a follow up I was thinking about logging since this is pretty silent and is
going to wind up surprising people. I wonder if we could print out at the start of the allocation
run a set of warnings. E.g.

```
I Performing allocation on N agents
W Framework F is MULTI_ROLE capable but some agents are not
W Framweork F is not RESERVATION_REFINEMENT capable; will not see refined reservations
etc
```

- Benjamin Mahler


On June 13, 2017, 8:44 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60038/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 8:44 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prevented allocating reservation refinements to non-capable frameworks.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 3428edfca116ffc625b683b6bead48300c2750c4

> 
> 
> Diff: https://reviews.apache.org/r/60038/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message