mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 60071: Updated test utilities for reservation refinement.
Date Wed, 14 Jun 2017 18:19:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60071/#review177930
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/mesos.hpp
Lines 732 (patched)
<https://reviews.apache.org/r/60071/#comment251636>

    2 blank lines.



src/tests/mesos.hpp
Line 875 (original), 894-895 (patched)
<https://reviews.apache.org/r/60071/#comment251640>

    do we prefer non-const reference to a pointer here?



src/tests/mesos.hpp
Line 875 (original), 894-900 (patched)
<https://reviews.apache.org/r/60071/#comment251642>

    can you move this to #911 and move `reservation` inside the if condition; to be consistent
with how you did it in #944



src/tests/mesos.hpp
Line 924 (original), 945 (patched)
<https://reviews.apache.org/r/60071/#comment251641>

    ditto.


- Vinod Kone


On June 14, 2017, 9:58 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60071/
> -----------------------------------------------------------
> 
> (Updated June 14, 2017, 9:58 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7669
>     https://issues.apache.org/jira/browse/MESOS-7669
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated test utilities for reservation refinement.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 48072a976cdbe6e655dc6f5f258abc6d737ed068 
> 
> 
> Diff: https://reviews.apache.org/r/60071/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message