mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 58250: Test that bind-mounted host network configuration is mounted readonly.
Date Wed, 14 Jun 2017 17:23:50 GMT


> On June 14, 2017, 4:41 a.m., James Peach wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp
> > Lines 1451 (patched)
> > <https://reviews.apache.org/r/58250/diff/5/?file=1750033#file1750033line1451>
> >
> >     This should be `ROOT_INTERNET_ReadOnlyBindMounts` because it doesn't need `curl`.

You still need CURL filter because downloading docker image needs curl (unfortunate, but this
is the case for now).


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58250/#review177862
-----------------------------------------------------------


On June 14, 2017, 2:12 p.m., Silas Snider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58250/
> -----------------------------------------------------------
> 
> (Updated June 14, 2017, 2:12 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Test that bind-mounted host network configuration is mounted readonly.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 3a5f4ebd4 
> 
> 
> Diff: https://reviews.apache.org/r/58250/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Silas Snider
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message