mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60062: Prevented reserve/create with hierarchical roles on a non-capable agent.
Date Wed, 14 Jun 2017 16:30:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60062/#review177911
-----------------------------------------------------------



A bit more detail in the commit message would be good: for example, how does this change relate
to ca8d33ab12d702612492928c0a5080bd459830bd ?


src/master/validation.cpp
Lines 1830 (patched)
<https://reviews.apache.org/r/60062/#comment251619>

    Seems unfortunate to have to pass in the `SlaveID` here just for error messages. I wonder
if the callers of `validate` can include the `SlaveID` in the error message they return when
validation fails?



src/master/validation.cpp
Lines 1856 (patched)
<https://reviews.apache.org/r/60062/#comment251620>

    We don't use single-quotes for capability names elsewhere.



src/tests/master_validation_tests.cpp
Lines 279 (patched)
<https://reviews.apache.org/r/60062/#comment251615>

    So we're passing an invalid (unset) `SlaveID` to the `validate` call below? Seems confusing.



src/tests/master_validation_tests.cpp
Lines 331 (patched)
<https://reviews.apache.org/r/60062/#comment251616>

    Setting this to `true` suggests to me that the test requires the hierarchical agent capability,
which isn't the case. I wonder if we want something like a `DEFAULT_AGENT_CAPABILITIES` constant?
    
    For now I'd just pass in a default-initialized `slave::Capabilities`, without `hierarchicalRole`
set.


- Neil Conway


On June 14, 2017, 9:52 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60062/
> -----------------------------------------------------------
> 
> (Updated June 14, 2017, 9:52 a.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prevented reserve/create with hierarchical roles on a non-capable agent.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
>   src/master/master.cpp 3c6925dc6055fb7cec12ec03bc557ad462863c58 
>   src/master/validation.hpp 6b53e34f67f6a8b338b92db6cb7398f1dccce5a9 
>   src/master/validation.cpp f45f9e816bdaf6304794604570edbd68d5faf715 
>   src/tests/master_validation_tests.cpp 4e7ce74edf0069b9317f869b299694a45e2a62f2 
> 
> 
> Diff: https://reviews.apache.org/r/60062/diff/3/
> 
> 
> Testing
> -------
> 
> Added new tests to `master_validation_tests.cpp` + `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message