mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 59949: Added `MESOS_CONTAINER_IP` to tasks launched by `DefaultExecutor`.
Date Wed, 14 Jun 2017 13:47:40 GMT


> On June 13, 2017, 6:42 p.m., Jie Yu wrote:
> > src/launcher/default_executor.cpp
> > Lines 371 (patched)
> > <https://reviews.apache.org/r/59949/diff/1/?file=1746882#file1746882line371>
> >
> >     I'd add a TODO here. Because for bridge mode, `self().address.ip` might be the
advertise IP (i.e., agent IP), which is not what we've wanted here.

>From a CNI perspective the BRIDGE mode is just another CNI network, so the self().address.ip
will be the IP on the BRIDGE network which is what is expected. So for the time being dropping
this comment. Please open if you still feel this is an issue.


> On June 13, 2017, 6:42 p.m., Jie Yu wrote:
> > src/launcher/default_executor.cpp
> > Lines 438 (patched)
> > <https://reviews.apache.org/r/59949/diff/1/?file=1746882#file1746882line438>
> >
> >     Let's add a TODO to document this Downward API.

Instead of a TODO, should we just create a JIRA and add it to the CNI documentation and the
executor documentation?


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59949/#review177778
-----------------------------------------------------------


On June 9, 2017, 6:39 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59949/
> -----------------------------------------------------------
> 
> (Updated June 9, 2017, 6:39 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Jie Yu.
> 
> 
> Bugs: MESOS-7631
>     https://issues.apache.org/jira/browse/MESOS-7631
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `MESOS_CONTAINER_IP` to tasks launched by `DefaultExecutor`.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574 
> 
> 
> Diff: https://reviews.apache.org/r/59949/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message