mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 58250: Test that bind-mounted host network configuration is mounted readonly.
Date Tue, 13 Jun 2017 21:53:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58250/#review177808
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/cni_isolator_tests.cpp
Lines 1451 (patched)
<https://reviews.apache.org/r/58250/#comment251534>

    Let's add INTERNET_CURL filter here because this requires docker registry



src/tests/containerizer/cni_isolator_tests.cpp
Lines 1490 (patched)
<https://reviews.apache.org/r/58250/#comment251543>

    I would split this into multiple lines. Also, please use multiple lines to stick to our
style guide:
    
    ```
    // Verify that the files are not readonly.
    command.add_arguments(
      R"~(
      mount | grep /etc/hosts &&
      test -w /etc/hosts &&
      test -w /etc/resolv.conf &&
      test -w /etc/hostname
      )~");
    ```


- Jie Yu


On June 13, 2017, 4:49 p.m., Silas Snider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58250/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 4:49 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Test that bind-mounted host network configuration is mounted readonly.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 3a5f4ebd4 
> 
> 
> Diff: https://reviews.apache.org/r/58250/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Silas Snider
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message