mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 60019: Removed the only use of `flatten` in Mesos core.
Date Tue, 13 Jun 2017 21:13:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60019/#review177803
-----------------------------------------------------------


Ship it!




Looks good, but of course it assumes the new format, which doesn't seem to be enforced?


src/common/resources.cpp
Line 1804 (original), 1804 (patched)
<https://reviews.apache.org/r/60019/#comment251532>

    How about 'r'?


- Benjamin Mahler


On June 13, 2017, 8:36 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60019/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 8:36 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed the only use of `flatten` in Mesos core.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp f89f1aae7845f1e93dd5947de2e7a8e2bfce8bc4 
>   src/v1/resources.cpp 24240eedc4b2747ca02998534437318c3396db4d 
> 
> 
> Diff: https://reviews.apache.org/r/60019/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message