mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 59949: Added `MESOS_CONTAINER_IP` to tasks launched by `DefaultExecutor`.
Date Tue, 13 Jun 2017 18:42:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59949/#review177778
-----------------------------------------------------------


Fix it, then Ship it!





src/launcher/default_executor.cpp
Lines 371 (patched)
<https://reviews.apache.org/r/59949/#comment251494>

    I'd add a TODO here. Because for bridge mode, `self().address.ip` might be the advertise
IP (i.e., agent IP), which is not what we've wanted here.



src/launcher/default_executor.cpp
Lines 438 (patched)
<https://reviews.apache.org/r/59949/#comment251493>

    Let's add a TODO to document this Downward API.



src/launcher/default_executor.cpp
Lines 447 (patched)
<https://reviews.apache.org/r/59949/#comment251491>

    Why WARNING here? use INFO instead?


- Jie Yu


On June 9, 2017, 6:39 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59949/
> -----------------------------------------------------------
> 
> (Updated June 9, 2017, 6:39 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Jie Yu.
> 
> 
> Bugs: MESOS-7631
>     https://issues.apache.org/jira/browse/MESOS-7631
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `MESOS_CONTAINER_IP` to tasks launched by `DefaultExecutor`.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574 
> 
> 
> Diff: https://reviews.apache.org/r/59949/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message