mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 59899: Test confirming the Docker containerizer stdout/stderr ownership.
Date Tue, 13 Jun 2017 01:35:00 GMT


> On June 8, 2017, 4:57 p.m., Joseph Wu wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 4316-4323 (patched)
> > <https://reviews.apache.org/r/59899/diff/1/?file=1744126#file1744126line4316>
> >
> >     Consider using `slave::paths::getExecutorRunPath` here instead.

Nice, thanks!


> On June 8, 2017, 4:57 p.m., Joseph Wu wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 4333-4334 (patched)
> > <https://reviews.apache.org/r/59899/diff/1/?file=1744126#file1744126line4333>
> >
> >     FYI, some other tests do `os::getuid("nobody")` instead and then assert the
UIDs.

I would go for that then instead of the pattern used in e.g. "src/tests/container_logger_tests.cpp::749"


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59899/#review177325
-----------------------------------------------------------


On June 7, 2017, 11:07 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59899/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 11:07 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test would fail before applying the Docker containerizer sandbox
> stdout/stderr ownership fix. Note that when we are setting a task-user,
> this test did not fail before - only when setting the framework-user
> but not the task-user.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 84e062a03c8c13bab5739e44031c91379362d417

> 
> 
> Diff: https://reviews.apache.org/r/59899/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message