mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 60029: Clean up disk isolator headers.
Date Mon, 12 Jun 2017 22:02:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60029/#review177677
-----------------------------------------------------------



Patch looks great!

Reviews applied: [60029]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On June 12, 2017, 2:18 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60029/
> -----------------------------------------------------------
> 
> (Updated June 12, 2017, 2:18 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Neither of the disk isolators needs anything from slave/state.hpp,
> so remove this from their header files.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.hpp 63684291b74251b6534bb65661c040c8256931c9

>   src/slave/containerizer/mesos/isolators/xfs/disk.hpp aced6d9409ff2e09fbf1ed412e7cbb45c43abbab

> 
> 
> Diff: https://reviews.apache.org/r/60029/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message