mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 60019: Removed the only use of `flatten` in Mesos core.
Date Mon, 12 Jun 2017 18:35:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60019/#review177658
-----------------------------------------------------------



Bad review!

Reviews applied: [60019, 60018, 60017, 60016, 60015, 60013, 59861, 59860, 59859, 58510, 58509,
58508, 57516, 58584, 57254, 58112, 58110, 57564, 57528, 57527, 57788, 57167, 57166, 56805,
57165, 57164]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos Reviewbot Windows


On June 12, 2017, 6:33 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60019/
> -----------------------------------------------------------
> 
> (Updated June 12, 2017, 6:33 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is the second step in removing the `flatten` function. This is the only use of `flatten`
within Mesos (we use them in example frameworks still). Potential follow-up work here is that
`find` itself doesn't seem to be used much either.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp f89f1aae7845f1e93dd5947de2e7a8e2bfce8bc4 
>   src/v1/resources.cpp 24240eedc4b2747ca02998534437318c3396db4d 
> 
> 
> Diff: https://reviews.apache.org/r/60019/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message