mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 60018: Renamed `flatten()` to `toUnreserved()`.
Date Mon, 12 Jun 2017 18:30:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60018/#review177657
-----------------------------------------------------------



Bad review!

Reviews applied: [60018, 60017, 60016, 60015, 60013, 59861, 59860, 59859, 58510, 58509, 58508,
57516, 58584, 57254, 58112, 58110, 57564, 57528, 57527, 57788, 57167, 57166, 56805, 57165,
57164]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos Reviewbot Windows


On June 12, 2017, 6:29 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60018/
> -----------------------------------------------------------
> 
> (Updated June 12, 2017, 6:29 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7655
>     https://issues.apache.org/jira/browse/MESOS-7655
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is the first phase in removing the `flatten` function. This patch in particular
only renames the `flatten()` function (not the `flatten(role, reservation)` version) to `toUnreserved`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 451b0cef6f84743e3d630104ba6f55665793f2bc 
>   include/mesos/v1/resources.hpp c790927353122a4eb2bbbee31c6df57d97f3994b 
>   src/cli/execute.cpp 11a2569f788a2ee1ceaf13ab0d40d1d1b275f27a 
>   src/common/resources.cpp f89f1aae7845f1e93dd5947de2e7a8e2bfce8bc4 
>   src/examples/balloon_framework.cpp bfaae3796afb426459ef5cff3a37634a8242032e 
>   src/examples/disk_full_framework.cpp a73e6cf285b9a74492d476a624915235e079051f 
>   src/examples/long_lived_framework.cpp bbe8606c8d2572bbbbad695e44fa23ce7b6129eb 
>   src/examples/test_framework.cpp 05ddc89d953d9b968b78f98fec819aeda7f79e26 
>   src/examples/test_http_framework.cpp 471835c349e0da031a540ed48881227a25887ba7 
>   src/master/allocator/mesos/hierarchical.cpp 73d0b42433a1ff3e853e851b8191864b4e233666

>   src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
>   src/tests/mesos.hpp 48072a976cdbe6e655dc6f5f258abc6d737ed068 
>   src/tests/reservation_endpoints_tests.cpp ba283ee74fe27998a01c43e1ab6a8ce0089181fa

>   src/tests/resources_tests.cpp 71c7544470f44f84ef90f9b31afcd81d46493981 
>   src/v1/resources.cpp 24240eedc4b2747ca02998534437318c3396db4d 
> 
> 
> Diff: https://reviews.apache.org/r/60018/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message